bernds / q5Go

A tool for Go players: SGF editor, analysis tool, game database and pattern search tool, IGS client
GNU General Public License v2.0
168 stars 28 forks source link

matches with inverted colors miscounted in pattern search #64

Closed nanzi closed 2 years ago

nanzi commented 2 years ago

Maybe it‘s a corner case in pattern search. I searched sansan in katago-60b-457 rating games and got 78 matches, which q5go told me 3 matches in white(inverted) colors. But after I counted with screen-print in case of missing or double counting, there were only 2 sgfs.

kata1-b60c320-s4577723904-d2458479936.tar.gz

Screenshot_2022-05-30_08-40-01

Screenshot_2022-05-30_08-44-02

nanzi commented 2 years ago

Excuse me, and what does "136+3=139 matches" indicate? In some search the invert color number is reliable(by coincidence?)

bernds commented 2 years ago

Could be a problem with the symmetry of the pattern causing double counting. Not sure yet.

bernds commented 2 years ago

I think this commit should fix it - please verify whether you still see problems.

nanzi commented 2 years ago

Cool. I have compiled the latest commit and both pattern counting (got 2 now) and game sum counting (got 76+2=78 now) are fixed now.