search

bertt / tango

2 stars 0 forks source link

Refactor: Treat warnings as errors #28

Open bertt opened 6 years ago

bertt commented 6 years ago

There are a lot of build warnings (225), partly in our code. Lets start with fixing those in our code. Most are removing unused variables


Unity] Assets/Geodan/Scripts/CloudServices.cs(22,13): warning CS0219: The variable `form' is assigned but its value is never used
[Unity] Assets/Geodan/Scripts/FloorMarkerTrail.cs(117,25): warning CS0168: The variable `target' is declared but never used
[Unity] Assets/Geodan/Scripts/NavigatorSystem.cs(247,36): warning CS0219: The variable `msg' is assigned but its value is never used
[Unity] Assets/Geodan/Scripts/RecordingSystem.cs(15,17): warning CS0414: The private field `RecordingSystem.markerCounter' is assigned but its value is never used
[Unity] Assets/Geodan/Scripts/CloudServices.cs(22,13): warning CS0219: The variable `form' is assigned but its value is never used
[Unity] Assets/Geodan/Scripts/FloorMarkerTrail.cs(117,25): warning CS0168: The variable `target' is declared but never used
[Unity] Assets/Geodan/Scripts/NavigatorSystem.cs(247,36): warning CS0219: The variable `msg' is assigned but its value is never used
[Unity] Assets/Geodan/Scripts/CloudServices.cs(22,13): warning CS0219: The variable `form' is assigned but its value is never used
[Unity] Assets/Geodan/Scripts/FloorMarkerTrail.cs(117,25): warning CS0168: The variable `target' is declared but never used
[Unity] Assets/Geodan/Scripts/NavigatorSystem.cs(247,36): warning CS0219: The variable `msg' is assigned but its value is never used
[Unity] Assets/Geodan/Scripts/RecordingSystem.cs(15,17): warning CS0414: The private field `RecordingSystem.markerCounter' is assigned but its value is never used
[Unity] Assets/Geodan/Scripts/CloudServices.cs(22,13): warning CS0219: The variable `form' is assigned but its value is never used
[Unity] Assets/Geodan/Scripts/FloorMarkerTrail.cs(117,25): warning CS0168: The variable `target' is declared but never used
[Unity] Assets/Geodan/Scripts/NavigatorSystem.cs(247,36): warning CS0219: The variable `msg' is assigned but its value is never used

``
aiunderstand commented 6 years ago

Agree

bertt commented 6 years ago

86 warnings left :-)

aiunderstand commented 6 years ago

98 in Cloud build, but 5 in editor. Note that in cloud build log these 5 are repeated 8 times and that [Unity] WARNING: ETC2 texture format is not supported, decompressing texture is repeated for 54 times. Not sure why that error is there since the editor emits no warning

aiunderstand commented 6 years ago

So with just 6 actions we could reduce it to almost a clean build sheet ;-)