search

besok / jsonpath-rust

Support for json-path in Rust
https://crates.io/crates/jsonpath-rust
MIT License
104 stars 27 forks source link

cleanup after 0.6.0 changes #66

Closed xMAC94x closed 5 months ago

xMAC94x commented 5 months ago

Thanks for the last PR merge.

I think there were some things missing, e.g. that I upaded the README to reflect the latest changes. I tried to do that here.

All changes should be backwards compatible, so a 0.6.1 release would do it, however I leave the release decision (whether and if so, how) to you.

I applied all cargo clippy lints, and they are now also checked for the whole repo. ( if found now workaround other than ![allow(clippy::empty_docs)], because the doc comment comes from an imported crate, via the Parser macro :/ )

Note regarding the license. I modified the Cargo.toml to show MIT as that is what the license-file currently contains. crates.io does not inspect the file itself, but just shows non-standard when license-file is used.

You might also consider to re-license your crate under dual MIT or Apache-2.0, e.g. like crates like https://github.com/dtolnay/syn do. Its what most rust projects (and rust Itself choose): https://www.rust-lang.org/policies/licenses

besok commented 5 months ago

Thanks for the pr.