bespoke-silicon-group / bsg_manycore

Tile based architecture designed for computing efficiency, scalability and generality
Other
214 stars 56 forks source link

Some minor issues #696

Open Yuan-Mao opened 1 year ago

Yuan-Mao commented 1 year ago

The following lines might need some attention:

  1. https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/v/bsg_manycore_pod_mesh_array.v#L106 Although it might actually be compatible, but global_x_li (and also global_y_li) has different dimension than the one declared in bsg_manycore_pod_mesh_row.v: https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/v/bsg_manycore_pod_mesh_row.v#L83

  2. https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/v/bsg_manycore_tile_compute_array_mesh.v#L117 Should use subarray_numtiles[xy]_p instead of numtiles[xy]_p.