search

besteon / Ironmon-Tracker

A Lua script for the Bizhawk/mGBA emulator compatible with Pokemon Fire Red, Leaf Green, Ruby, Sapphire, and Emerald that tracks relevant data for the IronMon challenge.
MIT License
122 stars 44 forks source link

Log Search Screen - Add Spacebar button #386

Closed Aeiiry closed 1 year ago

Aeiiry commented 1 year ago

Simple change to add a spacebar button to the log search screen keyboard. Allows for better searching for things such as "dragon rage" or "fire punch"

UTDZac commented 1 year ago

If you end up adding a clear button [X] next to the back arrow, then I think you can also do away with the clearing of search text when the filter dropdown box changes. I know originally I had you clear this out, but if the clear button is there then its really easy for the user to clear it out themselves.

I think a more common use case is to start typing "THUNDER" then realize they are on the "Pokémon Name" filter, changing it to "Levelup Move" which clears out all that text they wrote in.

So yeah, I you had it right the first time, just needed a way to single button clear out.

Aeiiry commented 1 year ago

image I've added a clear button to the right of backspace. Currently the backspace image is misaligned vertically but that's a minor issue. Additionally I moved the labels for "Sort by:" and "Filter" down 1px as they were slightly too high.

UTDZac commented 1 year ago

All of this looks great. Thanks for adding in the extra buttons