bestmomo / laravel-email-confirmation

Add email confimation to Laravel project
89 stars 28 forks source link

fixed to save confirmation_code even when resend action #12

Closed kichon closed 6 years ago

kichon commented 6 years ago

Hello I fixed it because the confirmation_code was not saved at the time of resend action

Please confirm it is

bestmomo commented 6 years ago

Hello, What is the point of creating a code that has already been created during registration?

kichon commented 6 years ago

@bestmomo thank you for reply.

My point is the fix when installed laravel-email-confirmation after users is already created.

I installed laravel-email-confirmation after user creation. so, my site user who did resent action dosen't have confirmation_code.

Certainly as you are saying, users who have been created after installed laravel-email-confirmation had confirmation_code.

if you don't need, i close this pull req.

bestmomo commented 6 years ago

Ok I understand, but add a condition to check if confirmation_code is empty to avoid useless base update.

kichon commented 6 years ago

@bestmomo thank you!

I changed it to check condition