search

betrusted-io / betrusted-soc

Betrusted main SoC design
Other
136 stars 21 forks source link

betrusted-soc/CRG: use LiteX's S7MMCM and remove slow_clock mode #12

Closed enjoy-digital closed 4 years ago

enjoy-digital commented 4 years ago

As discussed in https://github.com/betrusted-io/betrusted-soc/issues/11, this should simplify the design and ease changing/adding clock frequencies in the future.

enjoy-digital commented 4 years ago

Have you been able to test it on hardware?

bunnie commented 4 years ago

stepped out for dinner as it's compiling. I'll load it up once I'm back home in about an hour.

thanks,

-b.

On January 1, 2020 7:21:15 PM GMT+08:00, enjoy-digital notifications@github.com wrote:

Have you been able to test it on hardware?

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/betrusted-io/betrusted-soc/pull/12#issuecomment-570045161

enjoy-digital commented 4 years ago

ok, BTW if you are not already aware of it, it's possible to test a pull request locally without merging it yet: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally

bunnie commented 4 years ago

I didn't know about this! that's very helpful, thanks.

The design seems to work OK, but some other bugs have crept in that I think are from other changes I made. I had also pulled the latest litex, which maybe wasn't the smartest idea for comparing revs. I'll keep digging into the current problem but I doubt it would be caused by the clock network refactor unless it somehow clobbered the UART baud generator.

bunnie commented 4 years ago

can confirm everything is looking good, figured out the last few bugs.

enjoy-digital commented 4 years ago

OK good, then i'll do some tests with the timings constraints as discussed in https://github.com/betrusted-io/betrusted-soc/issues/10 and will send a PR.