search

better / convoys

Implementation of statistical models to analyze time lagged conversions
https://better.engineering/convoys/
MIT License
254 stars 42 forks source link

Linear regression #99

Closed erikbern closed 5 years ago

erikbern commented 5 years ago

Add a corresponding linear model to the previous logistic model

~Test is failing. I think my log-likelihood function is incorrect, but I'm too tired to figure out why. Will debug more later.~

Seems like my latest log-likelihood function resolves the issue, but it was admittedly a bit of trial and error and I'm going to try to rationalize it before merging.

Most of this is just cleanup of constructor parameters

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 95.368% when pulling 2c9334b20721705e57fa8d215d9e4f2982f96fd6 on linear-regression into 471b55e550e0b74e6c42157a56ac66c28022c3b5 on master.