betterphp / InfinitePlots

A plugin for Bukkit based Minecraft server that can generate infinite square plots of a configurable size.
http://dev.bukkit.org/server-mods/infiniteplots/
3 stars 4 forks source link

Multiple different sized plots [Suggestion] #29

Closed ghost closed 11 years ago

ghost commented 11 years ago

This used to be done by appending a colon and then the desired size of the plots when creating a plot world.

/mv create NewPlotWorld normal -g InfinitePlots:100

betterphp commented 11 years ago

This was removed due to a complication with the claim system, it was effectively replaced with the option to enable building between owned plots as that creates more flexibility. I do agree it was a useful feature though so will accept this for now until we work out why it was not kept :P

ghost commented 11 years ago

All the calculations on plot sizes are based on a value in the config file right? Surely you could have something like, "if there is a value after the colon in the multiverse world config, use that value, if else, use the value in config".

The building between plots option is really very cool but how does that have anything to do with this?

betterphp commented 11 years ago

The ID is not a Mutliverse specific thing so that would not work. It is possible to get it from the instance of the world generator but I seem to remember there being a reason we could not do that here.

hskrasek commented 11 years ago

We could modify the generator to take into account the custom plot size, but we had no sensical way to store that custom size for the claim system to utilize, since it uses the plot size to calculate exactly where the build able region of the plot is.

hskrasek commented 11 years ago

Or atleast I think that's why we didn't reimplement that :size thing

EDIT: Changed you to we, cause typing is hard

betterphp commented 11 years ago

The :size thing is actually :ID and it gets passed to JavaPlugin.getDefaultWorldGenerator(String worldName, String id); as the id parameter. You can store that in the instance of the generator for that world and get it from a World using that

int size = world.getGenerator().getPlotSize();

for example. So it should be accessible wherever we need it, but I'm sure there was a reason why this was not workable.

ghost commented 11 years ago

If this proves too difficult, perhaps we could have another file, worlds.yml, which stores the plot sizes for each of the worlds. And for a new plot world where there is no size specified in the worlds.yml file, it could get the default one from the config.yml.

Just an idea ;)

hskrasek commented 11 years ago

@betterphp Did not know that, once again proving you have used the Bukkit API longer than I have :P. But I cannot remember the reason we said this wasn't workable, but we could always look at it again and see if that refreshes our memory.

@JohnnyBlu I personally would want to stay away from the worlds.yml file that only stores one bit of information, just because it is a waste in my own opinion. But that could definitely work though.

I think this is something to look at again once we have the time and are knocking some other things out, and see if we can remember the reason why this wasn't workable, or have a brain blast moment and find a way to accomplish this.

ghost commented 11 years ago

What other stuff are you knocking out?

I may try my hand at solving this, but I can just about move buttons around in MCP so I'm no pro.

hskrasek commented 11 years ago

Uhm at the moment, its just some things that have enhancement issues created and assigned to myself, and some other ideas that @betterphp has. But we have both been very busy and thus unable to chat for a long period of time to get an idea of what all we need/want to do before making a release.