bevyengine / bevy

A refreshingly simple data-driven game engine built in Rust
https://bevyengine.org
Apache License 2.0
35.35k stars 3.49k forks source link

Async-Executor v1.9.0 Selected by Cargo Locks up the engine #12044

Closed dt665m closed 6 months ago

dt665m commented 7 months ago

Bevy version

Bevy 0.12.1

[Optional] Relevant system information

macOs Sonoma

What you did

Shared a Project without Cargo.lock checked in. A new Cargo.lock resolved by cargo Resolves to Async-Executor 1.9.0, which locks up the game at the very start. This is very hard to bisect when many things are different in Cargo.lock

Additional information

Either something changed with async-executor that is more than a small bump (not exactly MINOR in semver) or perhaps there is a bug. Maybe bevy can lock the dependency.

Temporary Fix

For those who might also run into this, we are explicitly pinning async-executor to 1.8.0 in our own Cargo.

james7132 commented 7 months ago

async-executor 1.9.0 has been yanked for now. New builds shouldn't be pulling it anymore. Going to continue to investigate why this happened, as this was a bug. In retrospect, having been working on both projects, I should have validated changes to async-executor worked with Bevy.

james7132 commented 6 months ago

Closing this out for now as async_executor has yet to publish a new version, but the issue has been fixed upstream. A new version has not been published due to a major regression in performance due to higher contention.