search

beyond-all-reason / Beyond-All-Reason

Main game repository for Beyond All Reason.
https://www.beyondallreason.info/
Other
1.7k stars 282 forks source link

Limit max sound output of game (add sound compression) #3212

Open sprEEEzy opened 3 months ago

sprEEEzy commented 3 months ago

Description

The current "air absorption" low pass filter isn't enough, the game needs sound compression. Game gets extremely loud as it goes later into the match, with no limit on sound levels.

Why?

Just had a crazy example where a lot of pings happened within a few seconds, and while rewinding replay at max speed - it literally blew my speakers out (even at 16% master volume and 50% gameplay volume!).

Another problematic situation is basically every late game scenario - if you zoom out, the game tries to play every sounds that's visible, and all those sounds compounding together create extremely loud sounds that shouldn't happen when you have the volume at 10%.

What area of the game does this feature request pertain?

UI/UX, Settings, Controls or Hotkeys, Other

Other (optional)

No response

Damgam commented 2 months ago

Each sound effect is currently limited to 8 at the time btw.

sprEEEzy commented 2 months ago

Each sound effect is currently limited to 8 at the time btw.

But is there a limit to total amount of sounds? As there are hundreds of different types of sounds playing at the same time...

Damgam commented 2 months ago

Each sound effect is currently limited to 8 at the time btw.

But is there a limit to total amount of sounds? As there are hundreds of different types of sounds playing at the same time...

256 iirc, and it's configurable somewhere but it's forced to be 256...... maybe revealing that as a slider in Audio settings is not a terrible idea?

sprEEEzy commented 2 months ago

Each sound effect is currently limited to 8 at the time btw.

But is there a limit to total amount of sounds? As there are hundreds of different types of sounds playing at the same time...

256 iirc, and it's configurable somewhere but it's forced to be 256...... maybe revealing that as a slider in Audio settings is not a terrible idea?

That'd be cool. A lot of games offer max sound channels options, but, the game needs to be smart about how it chooses sounds to play then.

icexuick commented 5 days ago

Each sound effect is currently limited to 8 at the time btw.

But is there a limit to total amount of sounds? As there are hundreds of different types of sounds playing at the same time...

256 iirc, and it's configurable somewhere but it's forced to be 256...... maybe revealing that as a slider in Audio settings is not a terrible idea?

That'd be cool. A lot of games offer max sound channels options, but, the game needs to be smart about how it chooses sounds to play then.

There should be a priority variable - so you can set sound-categories to have different priorities. Higher priority sounds should cut off lower ones, though my experience is that it will only play when a sound-channel is free. Also we'd probably need to cut/re-structure all 1000+ sounds into separate folders (categories) and assign priorities to them.

And I actually not sure what sounds to prioritize. I want to hear sounds that come from every unit (movement, replies, weapon-fire, and also certainly all explosions. These are important queues. Atmospheric sounds already are lower priority.

I would love a harder/stronger air-absorption where it would cut-off / not play more distant sounds (if channels are full).

Damgam commented 5 days ago

Start with prioritising UI sounds. Unit replies, clicks, Announcer...