search

beyond-all-reason / teiserver

Middleware server for online gaming
https://www.beyondallreason.info/
MIT License
61 stars 52 forks source link

Incorrect syntax for the REMOVESCRIPTTAGS command #196

Open p2004a opened 12 months ago

p2004a commented 12 months ago

Teiserver is incorrectly using tabs instead of spaces to separate arguments of the REMOVESCRIPTTAGS command. Per https://springrts.com/dl/LobbyProtocol/ProtocolDescription.html#REMOVESCRIPTTAGS:client those are arguments, no sentences, so spaces should apply.

Teifion commented 12 months ago

I have hotfixed this in, please let me know if I can close the issue @p2004a

p2004a commented 12 months ago

Are you sure it's deployed uniformly across all rooms?

I still see

20231114201634 - WARNING  - [SpringLobbyInterface] Ignoring unknown script tag in REMOVESCRIPTTAGS "game/players/sgrosser/skilluncertainty      game/players/sgrosser/skill"

and double checked another room, room started at 20231114203600, the message is there:

20231114203629 - WARNING  - [SpringLobbyInterface] Ignoring unknown script tag in REMOVESCRIPTTAGS "game/players/warpface/skilluncertainty      game/players/warpface/skill"
p2004a commented 11 months ago

@Teifion Almost there I think, checked logs right now and I see:

20231119083407 - WARNING  - [SpringLobbyInterface] Ignoring unknown script tag in REMOVESCRIPTTAGS ""

so like sending commands when there aren't any arguments? or something like that?

L-e-x-o-n commented 2 months ago

Is this still an issue?

p2004a commented 2 months ago

Yes

debian@spads-eu1:~$ cat /home/spads/spads/var/ClusterManager/Host\[EU1\]\[001\]/log/spads.log | grep REMOVESCRIPTTAGS | tail -n 1
20240822201507 - WARNING  - [SpringLobbyInterface] Ignoring unknown script tag in REMOVESCRIPTTAGS ""