search

bezmi / homeassistant_jvc_projector_remote

Custom components for homeassistant
Apache License 2.0
14 stars 11 forks source link

Update to incorporate power_state #2

Closed markprins closed 3 years ago

markprins commented 4 years ago

This incorporates the use of the PowerState in jvc_projector, and staged in pull request: https://github.com/bezmi/jvc_projector/pull/5

It should be fully backwards compatbile (ie: if integrations depend on it, it should still work as the base state is still on/off). Because the dependency on jvc_projector and its pull-request I could not test it in ideal situations. I did however test it by depending on my local jvc_remote project.

When accepting this, an update should be done to the manifest.json (i guess it will be 0.0.3)

markprins commented 4 years ago

You were right, I forgot to refactor the turn_on() function. It is updated now!

markprins commented 4 years ago

I have introduced two try/catches in the code. It is a (deliberate) broad exception (see commit message for details).

I was also considering refactoring the jvc_projector some more so handling commands and receiving commands is handled in a more general way (making it easier to handle exceptions). However that was a can of worms and decided to ponder a bit about it :) I'll create an issue about it.