bf2fc6cc711aee1a0c2a / architecture

Repository containing the architecture documents.
https://architecture.bf2.dev/
Apache License 2.0
5 stars 20 forks source link

Override github url #11

Closed wtrocki closed 2 years ago

wtrocki commented 2 years ago

Reverts redhat-developer/app-services-architecture#10

wtrocki commented 2 years ago

Plugin provides metadata and it works locally but somehow fails on deployment: https://jekyll.github.io/github-metadata/site.github/

Not sure why I done hack based on docs: https://github.com/pages-themes/leap-day#overriding-github-generated-urls

So that will specify this value explicitly.

wtrocki commented 2 years ago

Still not sure if that is going to work. It always worked locally.

tombentley commented 2 years ago

Let's try it. I suppose that upgrading jekyll would be an alternative thing to try, but a bigger change than this.

wtrocki commented 2 years ago

Actually I have missed that info in logs when locally:

GitHub Metadata: No GitHub API authentication could be found. Some fields may be missing or have incorrect data.

So proper fix is to not use that and hardcode values or use github api key