search

bf2fc6cc711aee1a0c2a / architecture

Repository containing the architecture documents.
https://architecture.bf2.dev/
Apache License 2.0
5 stars 20 forks source link

add adr-83 permission api #52

Closed ziccardi closed 2 years ago

ziccardi commented 2 years ago

ADR-83: Permission API

This ADR propose a way for the Kas Fleet Manager API consumers to check in advance whether a certain request would be successful.

Closes #48

ziccardi commented 2 years ago

@pb82 @wtrocki @tombentley @emmanuelbernard Mind giving a look please?

ziccardi commented 2 years ago

@pmuir made some changes to get closer to Kubernetes model.

ziccardi commented 2 years ago

@emmanuelbernard Mind another look?

wtrocki commented 2 years ago

While we still have some feedback and suggestions to apply, ADR as whole brings very good pattern that can help us to simplify data models and validation for UI and CLI. From my personal point of view this can be great supplement to our existing API and replace them completely after we will have all clients migrated

TL;DR - This API will be very useful. Thank you for creating ADR as we could later recommend the same pattern for other services as well

ziccardi commented 2 years ago

@emmanuelbernard @tombentley @chirino @wtrocki Renamed the ADR and addressed your comments. Mind giving another look?

ziccardi commented 2 years ago

@tombentley I applied the suggested change as we discussed. I however left the metadata for the reasons array: that's because we can have many reasons for an action to be refused and each reason will carry different details. For example: