search

bf2fc6cc711aee1a0c2a / architecture

Repository containing the architecture documents.
https://architecture.bf2.dev/
Apache License 2.0
5 stars 20 forks source link

ADR-90 & AP-17: add an architecture pattern for certificate management #84

Closed machi1990 closed 1 year ago

machi1990 commented 1 year ago

This follows up on https://github.com/bf2fc6cc711aee1a0c2a/architecture/pull/83

Instead of recommending generating a certificate per data plane cluster, we now recommend generating a certificate per managed instance. The ADR-89 has been superseded by a new ADR-90 which now talks about generating a certificate per Kafka instance.

emmanuelbernard commented 1 year ago

hey @machi1990, happy new year :) I wanted to highlight to you that we are using a template for APs https://architecture.appservices.tech/ap/0/ Might be good to use it early on.

machi1990 commented 1 year ago

Hey @emmanuelbernard bonne année :-)

Thanks for the pointers. I've it on my TODO list (after long PTO) and will get to it eventually.

machi1990 commented 1 year ago

Hey @emmanuelbernard bonne année :-)

Thanks for the pointers. I've it on my TODO list (after long PTO) and will get to it eventually.

Done. This is ready for another round of review @emmanuelbernard

machi1990 commented 1 year ago

Hi @pb82 @emmanuelbernard I've revisited the architecture pattern following recent Architecture discussions. I've also created a new ADR-90 to supersede ADR-89 - certificate per data plane Please have a look.

tombentley commented 1 year ago

@emmanuelbernard could you do another pass?

machi1990 commented 1 year ago

General LGTM, I have a question on the AP. Not sure we should always have to use a wildcard

Thank you. I'll update the AP to mention other possibilities e.g a certificate per route of a managed instance.

machi1990 commented 1 year ago

Hey folks, the review comments have been addressed. Bumping this for further review if needed or merging it. Thanks

tombentley commented 1 year ago

@lburgazzoli please can you review?

tombentley commented 1 year ago

Also @maleck13 are you happy with this now?

machi1990 commented 1 year ago

@maleck13 @lburgazzoli can you've a look? Thanks

machi1990 commented 1 year ago

@maleck13 @lburgazzoli friendly ping to have a look at this PR. I'd like to merge this soon if possible, thanks. /cc @emmanuelbernard @tombentley

machi1990 commented 1 year ago

The reviews feedback on this PR has been addressed. Can we get this one merged? Thanks @emmanuelbernard @tombentley

machi1990 commented 1 year ago

pushed a rebase change to fix conflicts.

@tombentley @emmanuelbernard can this PR be merged? Thank you

davidffrench commented 1 year ago

@tombentley @emmanuelbernard Is there anything blocking this being merged?

machi1990 commented 1 year ago

Thanks @tombentley