bflad / chef-stash

Chef Cookbook for Atlassian Stash
Other
37 stars 42 forks source link

Update mysql cookbook (6.x) and database cookbook #103

Closed patcon closed 9 years ago

patcon commented 9 years ago

I think we could do this pretty easily. Looking at the other issue, it seems the only problem was that when the database cookbook bumped major versions, it abstracted out a recipe (mysql2_chef_gem), and I think we could just add that back in

linc01n commented 9 years ago

Hmm... When I test run it, it gives me error

==> centos6: NoMethodError
==> centos6: -------------
==> centos6: undefined method `version' for Chef::Resource::MysqlClient
==> centos6:
==> centos6:
==> centos6: Cookbook Trace:
==> centos6: ---------------
==> centos6: /tmp/vagrant-chef/6d85d9c914cef1b3ceae556d9c1d3737/cookbooks/mysql2_chef_gem/libraries/provider_mysql2_chef_gem_mysql.rb:17:in `block (2 levels) in <class:Mysql>'
==> centos6: /tmp/vagrant-chef/6d85d9c914cef1b3ceae556d9c1d3737/cookbooks/mysql2_chef_gem/libraries/provider_mysql2_chef_gem_mysql.rb:16:in `block in <class:Mysql>'
patcon commented 9 years ago

Seems you're still using v5.x mysql cookbook series? Maybe check your berksfile.lock to confirm? (You want to be on v6.x now)

linc01n commented 9 years ago

I am afraid I was locked to 5.x

https://github.com/bflad/chef-stash/pull/103/files#diff-9fd042d4cd1e8f82894bbd7dffb313ecR30

mrjcleaver commented 9 years ago

There seems to be a bunch of code in various branches on the network https://github.com/bflad/chef-stash/network, including @andrewgoktepe 's at https://github.com/andrewgoktepe/chef-stash/commit/465275220f9876fb57154bf96115a31773d1bdb2

patcon commented 9 years ago

FYI, I think I got this working, but let's get postgresql test suite (#107) running before merging this, and I can rebase

(I'm using it from my feature branch for mysql, but not postgresql yet, and can't say with 100% certainty that it works for both)

patcon commented 9 years ago

Just rebased on master and updated issue title to better reflect work

EDIT: Haven't yet run tests. I'll get cloud testing (#108) working tomorrow before getting to this, as I expect some tests broke (particularly postgresql)

linc01n commented 9 years ago

:+1: Merged but I changed README.md and metadata.rb