search

bflad / chef-stash

Chef Cookbook for Atlassian Stash
Other
37 stars 42 forks source link

Add repo permissions support #99

Open drrk opened 9 years ago

drrk commented 9 years ago

Add the ability to control the permissions of a repo that is managed with the LWRP.

Adds 6 attributes for admin, write and read permissions for users and groups in stash. It will ensure that the permissions set in the LWRP are applied, both to add and remove users/groups.

In addition this PR slightly alters the behaviour of the chef-stash install, to only override the gem source from the system default if specified in the attributes.

bflad commented 9 years ago

I copied the other maintainers on #109 to see if we should worry about adding tests before/after this PR so you don't have to wait. Have you been using this in a branch okay? If you have ideas for LWRP testing, please feel free to comment on that other issue. Thank you!

drrk commented 9 years ago

I have been using it at a customers site, although that was before I cleaned up the branch for the PR. Sorry i've not looked at this in the last couple of weeks, I have been busy with another customer. I will have another look at fixing the remaining rubocop errors this week, and will discuss with some colleagues about LWRP testing strategies.