search

bh2smith / dune-sync

GNU General Public License v3.0
2 stars 2 forks source link

Support SQL files in Postgres sources #50

Closed mooster531 closed 3 weeks ago

mooster531 commented 3 weeks ago

Closes #44

mooster531 commented 3 weeks ago

While I'm at (or near) it - thoughts on converting this return False to a raise RuntimeError?

# src/sources/postgres.py

        except SQLAlchemyError as e:
            log.error("Invalid SQL query: %s", str(e))
            return False

Reasoning: the application couldn't possibly do anything useful if the SQL query is invalid. We don't need to let it continue with a broken initial state.