namespace didn't remove experiments from segmentAllocations after invoking RemoveExperiment()

biased-unit / planout-golang

(Multi Variate Testing) Interpreter for Planout code written in Golang

Apache License 2.0

7 stars 23 forks source link

namespace didn't remove experiments from segmentAllocations after invoking RemoveExperiment() #4

Open panjf2000 opened 6 years ago

panjf2000 commented 6 years ago

namespace didn't remove experiments from segmentAllocations after invoking RemoveExperiment() and it caused "panic: runtime error: invalid memory address or nil pointer dereference" in

tsujeeth commented 6 years ago

Thanks @panjf2000 for this change. Could you please add unit tests?

panjf2000 commented 6 years ago

@tsujeeth sure, i will add unit tests later.

panjf2000 commented 6 years ago

@tsujeeth already added unit tests, please review that.

tsujeeth commented 6 years ago

@panjf2000 sorry it has taken me a while to get back.

Some comments:

It would be helpful if the scope of your change is focused only on the issue: namespace didn't remove experiments from segmentAllocations. Could you please remove the other commits? Perhaps file a separate PR for them?
Please resolve merge conflicts. Note that biased-unit/planout-golang was recently updated