bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

fix(expr): Coerce arguments to min/max to numbers #2038

Closed effigies closed 4 months ago

effigies commented 4 months ago

max(events.columns.onset) was always null, because the column contains strings. Here we coerce values to numbers and filter nans, which gives us the behavior we want.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.12%. Comparing base (5de6cdd) to head (6f3b82d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2038 +/- ## ========================================== + Coverage 85.75% 87.12% +1.37% ========================================== Files 91 136 +45 Lines 3785 6449 +2664 Branches 1218 1551 +333 ========================================== + Hits 3246 5619 +2373 - Misses 453 740 +287 - Partials 86 90 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.