search

bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

rf: Rewrite readEntities to give more intuitive results #2063

Closed effigies closed 3 months ago

effigies commented 3 months ago

The unintuitive results occur for directories, mainly. Expand out the tests to cover more cases. Also return the stem, in case that's useful.

@rwblair This should be an easy one to review. This is needed for a PR I have planned that will replace FileTrees for directories with BIDSFiles that summarize their contents, pruning the tree and allowing more usual rules to apply to them.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.04%. Comparing base (56d686c) to head (614976b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2063 +/- ## ========================================== + Coverage 85.75% 87.04% +1.28% ========================================== Files 91 138 +47 Lines 3785 6622 +2837 Branches 1218 1572 +354 ========================================== + Hits 3246 5764 +2518 - Misses 453 768 +315 - Partials 86 90 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.