Closed effigies closed 3 months ago
Attention: Patch coverage is 79.41176%
with 21 lines
in your changes missing coverage. Please review.
Project coverage is 87.14%. Comparing base (
12f40bb
) to head (e710edd
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Dataset issues sensibly accumulate on the long-lived dataset object, instead of the ephemeral context object.
dataset.tree
is defined by the schema, and also makes sense there.I think
walk.ts
demonstrates this well. The dataset context provides the files to be iterated over, and a new context can be generated with just the current file and the dataset context.There's still room to pre-allocate a
context.subject
object and pass that through, but this is enough of a change for one PR, IMO.This will help focus #2057 on the specific changes needed for those issues.