search

bids-standard / pybids

Python tools for querying and manipulating BIDS datasets.
https://bids-standard.github.io/pybids/
MIT License
225 stars 122 forks source link

FIX: Filtering in BIDSLayoutIndexer #1063

Open alperkent opened 6 months ago

alperkent commented 6 months ago

Resolves (partially) #1062.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.74%. Comparing base (20007e5) to head (9b9c74e).

Files Patch % Lines
bids/layout/index.py 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1063 +/- ## ========================================== - Coverage 89.80% 89.74% -0.06% ========================================== Files 63 63 Lines 7177 7179 +2 Branches 1374 1375 +1 ========================================== - Hits 6445 6443 -2 - Misses 532 535 +3 - Partials 200 201 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adelavega commented 4 months ago

I'm not sure tbh.

I traced this back to; https://github.com/bids-standard/pybids/pull/560

Then Yarkoni moved it around.

Looks like we thought at the time that meta-data indexing was the most time consuming step, and implemented a way to skip meta-data indexing for a subset of files, rather then excluding them from being indexed altogether.