bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
90 stars 59 forks source link

fix(core): make selected account tab visible for user by default on mobile devices #1056

Closed bc-yevhenii-buliuk closed 1 month ago

bc-yevhenii-buliuk commented 1 month ago

What/Why?

This PR makes selected account tab visible for user by default on Mobile devices even after reloading the page.

Testing

locally

before:

https://github.com/bigcommerce/catalyst/assets/82589781/dc82a192-ef8c-4131-ab55-9e60381590e5

after:

https://github.com/bigcommerce/catalyst/assets/82589781/25e83dce-6b51-43b5-b67f-691a10b68328

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: f3a9903c5565907f3e027d86b5c1a13f0ce509b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 2:46pm
5 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/4dpHM66Yuw1mAfRUV8r7L6DQRWnm)) | [Visit Preview](https://catalyst-1millionproducts-store-git-6e290f-bigcommerce-platform.vercel.app) | | Jul 4, 2024 2:46pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/HfwueLpyygKofHsQjLx1uFw1GEpS)) | [Visit Preview](https://catalyst-au-git-fix-selected-account-tab-bigcommerce-platform.vercel.app) | | Jul 4, 2024 2:46pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/Gi5tRFvdWrvUG8wrjGcJHSvvipjd)) | [Visit Preview](https://catalyst-test-store-git-fix-selecte-da2615-bigcommerce-platform.vercel.app) | | Jul 4, 2024 2:46pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/7J1ijDrAX1PeUfwJuuPysHpJPnBf)) | [Visit Preview](https://catalyst-uk-git-fix-selected-account-tab-bigcommerce-platform.vercel.app) | | Jul 4, 2024 2:46pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/7KS7Me7qmSk8QjwRBpQ518B5bFbT)) | [Visit Preview](https://catalyst-unstable-git-fix-selected-18c4f6-bigcommerce-platform.vercel.app) | | Jul 4, 2024 2:46pm |
github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-6c09f0ue0-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92