Closed bookernath closed 1 month ago
Latest commit: 03a9b8cd547d75c84646669500c1c29f1c9002b2
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
catalyst-latest | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 8, 2024 7:30pm |
Lighthouse ran against https://catalyst-latest-d0jwd5znr-bigcommerce-platform.vercel.app
We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
Category | Score |
---|---|
🟠 Performance | 80 |
🟢 Accessibility | 100 |
🟢 Best practices | 100 |
🟠 SEO | 82 |
We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
Category | Score |
---|---|
🟢 Performance | 96 |
🟢 Accessibility | 100 |
🟢 Best practices | 100 |
🟠 SEO | 85 |
What/Why?
It's better to return empty strings than bad defaults for this meta information, so I'm removing these generic references to Catalyst in favor of empty strings.
For the case of the page title - stores will generally have a Store Name set (it's part of the trial form), so the case that this fails to return something is very unlikely.
In the case of meta description, we will update the API to return this information and update this file once again when that's ready. It can be specified manually by end users until that time (and it already pulls from the API on most entity pages like products, etc).
Testing
Preview URL