bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
90 stars 59 forks source link

Remove generic defaults for meta information #1073

Closed bookernath closed 1 month ago

bookernath commented 1 month ago

What/Why?

It's better to return empty strings than bad defaults for this meta information, so I'm removing these generic references to Catalyst in favor of empty strings.

For the case of the page title - stores will generally have a Store Name set (it's part of the trial form), so the case that this fails to return something is very unlikely.

In the case of meta description, we will update the API to return this information and update this file once again when that's ready. It can be specified manually by end users until that time (and it already pulls from the API on most entity pages like products, etc).

Testing

Preview URL

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 03a9b8cd547d75c84646669500c1c29f1c9002b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 7:30pm
5 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/DdmT2CVFMiNaWczNFZLfMrSXB9YZ)) | [Visit Preview](https://catalyst-1millionproducts-store-git-9b05a2-bigcommerce-platform.vercel.app) | | Jul 8, 2024 7:30pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/CmdpbggfuTJEyRKBF6XyYdqU8oT5)) | [Visit Preview](https://catalyst-au-git-meta-defaults-bigcommerce-platform.vercel.app) | | Jul 8, 2024 7:30pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/A7tVAYsySLYP1axBVFivfoBNB8cp)) | [Visit Preview](https://catalyst-test-store-git-meta-defaults-bigcommerce-platform.vercel.app) | | Jul 8, 2024 7:30pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/7kBnr8KHLcixZQ2pKiK95ujNEyPh)) | [Visit Preview](https://catalyst-uk-git-meta-defaults-bigcommerce-platform.vercel.app) | | Jul 8, 2024 7:30pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/2z9HZvbAPMnJC1AWQxqTzfrkH6gi)) | [Visit Preview](https://catalyst-unstable-git-meta-defaults-bigcommerce-platform.vercel.app) | | Jul 8, 2024 7:30pm |
github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-d0jwd5znr-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 80
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 85