bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
90 stars 59 forks source link

feat(core): allow setting a channel id in kv #1074

Closed jorgemoya closed 1 month ago

jorgemoya commented 1 month ago

What/Why?

With multi-channel work, we need to be able to get kv's for each specific channel. With this change we can set a channel id or use default as before.

Testing

Locally each channel has individual kv pairs.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 7:54pm
5 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/7Daixke5VxtAbxoWhkzbwpsJX3bT)) | | | Jul 8, 2024 7:54pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/CE6aTBYg24kqWWCge9iZKQ3WcY4i)) | | | Jul 8, 2024 7:54pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/6QCLU2r1iSPSm84sHEep7e7mWuG2)) | | | Jul 8, 2024 7:54pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/F13ubfB1Evs1SAU5fLoKs6uLr2op)) | | | Jul 8, 2024 7:54pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/6n3HEKG8uoghcxi9UNdz9mkDR6av)) | | | Jul 8, 2024 7:54pm |
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 74f7dd0a2f0052803bbd65fb931d872543c7008f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-3pnyrxsku-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 91

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92
jorgemoya commented 1 month ago

Closing to try a different approach.