bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
90 stars 59 forks source link

feat(core): append channel to kv key to make it channel aware #1075

Closed jorgemoya closed 1 month ago

jorgemoya commented 1 month ago

What/Why?

We need for kv keys to be channel aware when using multiple locales.

Testing

Locally each locale/channel has its own kv pairs.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 4:15pm
5 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/4Cc6tRBTU6qd2deEQSB1f2dLe1RY)) | [Visit Preview](https://catalyst-1millionproducts-store-git-a453f4-bigcommerce-platform.vercel.app) | | Jul 9, 2024 4:15pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/28yJ6X6159EXiyhWrVtBDjNzq8TD)) | [Visit Preview](https://catalyst-au-git-kv-channel-bigcommerce-platform.vercel.app) | | Jul 9, 2024 4:15pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/5j63PXScJT2jE8N5HKnJVEmiqKAK)) | [Visit Preview](https://catalyst-test-store-git-kv-channel-bigcommerce-platform.vercel.app) | | Jul 9, 2024 4:15pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/62gVWpHZg62RLFn9MkQg5QAUsfe5)) | [Visit Preview](https://catalyst-uk-git-kv-channel-bigcommerce-platform.vercel.app) | | Jul 9, 2024 4:15pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/bk8eYhpeRmWgptNTsyrzTABfCEZK)) | [Visit Preview](https://catalyst-unstable-git-kv-channel-bigcommerce-platform.vercel.app) | | Jul 9, 2024 4:15pm |
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: f4914a3c2e111be2996c19bdffd8228d9238c896

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-ny1bwvr61-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 93
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 91
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 85