bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
90 stars 59 forks source link

fix(core): issue with imports in change password form #1081

Closed jorgemoya closed 1 month ago

jorgemoya commented 1 month ago

What/Why?

Due to recent changes, change password form was erroring out because it's a client component importing a schema from a file with a our client defined within and it would throw an error because it can't read from env file.

Screenshot 2024-07-10 at 11 31 11 AM

This fixes the issue by moving around the schema definitions so that it doesn't clash when importing in a client component.

Testing

Locally it doesn't error.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 851181d418c6bd4c29c96e3b0de6a43e7d070655

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 4:32pm
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/EQzk8JgmAmBpQzreJpqMc56P8jUR)) | | | Jul 10, 2024 4:32pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/Fk5z3PkwUSq7gPDZwKo2stqt8gdx)) | | | Jul 10, 2024 4:32pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/9Smi74kjv6j6AjyYNc2hDfxdtPmb)) | | | Jul 10, 2024 4:32pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/FQ6S7RZ98QVQgiafYGdZGu8dS5Ke)) | | | Jul 10, 2024 4:32pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/EYDBBUcryS2kNVaYjXU7rxEcRyVq)) | | | Jul 10, 2024 4:32pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/Nk7ntTLMozR4TPG5pxPNtttZoSLS)) | | | Jul 10, 2024 4:32pm |