Open bc-yevhenii-buliuk opened 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
catalyst-latest | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 28, 2024 2:17pm |
Latest commit: d52081d505c88cec2262e5c3ee1e78689d8f8700
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
This PR implements appearance of success banner by adding a search parameter to the URL. Thanks to this parameter we can control banner appearance.
Another possible solution to implement was to use the context and change its status to "success"
after redirecting to the account page, but due to reloading the browser after the redirect, the context returns to its initial state with an "idle"
status, which does not allow the banner to be displayed.
Open to suggestions, thanks!
Hey @bc-yevhenii-buliuk, do you think you can rebase and merge this if test pass? 🙏
Hey @bc-yevhenii-buliuk, do you think you can rebase and merge this if test pass? 🙏
@jorgemoya yes, sure! I'm making final edits after testing this PR and plan to merge it soon.
Lighthouse ran against https://catalyst-latest-ignke6rfq-bigcommerce-platform.vercel.app
We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
Category | Score |
---|---|
🟠 Performance | 89 |
🟢 Accessibility | 100 |
🟢 Best practices | 96 |
🟠 SEO | 82 |
We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
Category | Score |
---|---|
🟢 Performance | 100 |
🟢 Accessibility | 100 |
🟢 Best practices | 96 |
🟠 SEO | 85 |
What/Why?
This PR improves redirect behavior after creating account, namely, it adds a banner about the successful creation of an account.
Testing
locally
before:
https://github.com/user-attachments/assets/12aaf09a-fc0c-44f3-b69e-d1e93be43131
after:
https://github.com/user-attachments/assets/7ff7469d-44b1-431c-978e-f4279fff2221