bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
90 stars 59 forks source link

Move sitemap fetching into the client #1098

Closed bookernath closed 1 month ago

bookernath commented 1 month ago

What/Why?

Moves sitemap index fetching into the client so it gets the benefits of everything the client offers (such as user agent), as well as making the client more useful within other systems who may also wish to use a sitemap.

I fixed some missing user agents on admin API requests while I was at it and also fixed hardcoded hostnames.

Testing

Preview build + server logs

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 8:29pm
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst/2ckfVGw8CmuDSFEFw2QsBNGMQwoB)) | | | Jul 16, 2024 8:29pm | | **catalyst-1millionproducts-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-1millionproducts-store/8DyWRL1nbtND6i5gKqcA7fbNymcL)) | [Visit Preview](https://catalyst-1millionproducts-store-git-75e519-bigcommerce-platform.vercel.app) | | Jul 16, 2024 8:29pm | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/FFPdg3qZ61L7h2EYnXrXtGP6b7By)) | [Visit Preview](https://catalyst-au-git-move-sitemap-fetchi-98e1bf-bigcommerce-platform.vercel.app) | | Jul 16, 2024 8:29pm | | **catalyst-test-store** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-test-store/EytRRQ55fFPWSS2hrkebqMgrxM8v)) | [Visit Preview](https://catalyst-test-store-git-move-sitema-0afd0d-bigcommerce-platform.vercel.app) | | Jul 16, 2024 8:29pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/2BmbjEvUmxJGmin7ozEeyGNB7YUZ)) | [Visit Preview](https://catalyst-uk-git-move-sitemap-fetchi-bdfa86-bigcommerce-platform.vercel.app) | | Jul 16, 2024 8:29pm | | **catalyst-unstable** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-unstable/21LiGfAz5y3viJT2oQ7PcwJrAX3x)) | [Visit Preview](https://catalyst-unstable-git-move-sitemap-07f53f-bigcommerce-platform.vercel.app) | | Jul 16, 2024 8:29pm |
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: b5e87700a6556fd04c4a63ecb26066cb37c9e901

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------------------------- | ----- | | @bigcommerce/catalyst-client | Minor | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-kxcmrtm6w-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85
bookernath commented 1 month ago

Storefront works ✅ Sitemap works https://catalyst-latest-kxcmrtm6w-bigcommerce-platform.vercel.app/sitemap.xml ✅ Shipping estimator on cart page works ✅ User agents observed in logs ✅