search

bigcommerce / catalyst

Catalyst - for Composable Commerce
https://catalyst-demo.site
MIT License
117 stars 150 forks source link

Missing translation strings #1690

Closed thebigrick closed 23 hours ago

thebigrick commented 1 day ago

What/Why?

Some of the aria-label attributes and a few strings were hardcoded. I added new entries to the en.json file and applied the translations in the TSX files.

Testing

Strings should yet be there. And should be translatable.

changeset-bot[bot] commented 1 day ago

🦋 Changeset detected

Latest commit: b77f2da9070a634a5d0a47c4ad24709a98cc92d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @bigcommerce/catalyst-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 day ago

@thebigrick is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

bookernath commented 1 day ago

Thanks @thebigrick!

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Nov 29, 2024 3:16pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 3:16pm
2 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **catalyst-au** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-au/AmapFtbH9w5T4MsbmaXphjrVzvkZ)) | [Visit Preview](https://catalyst-au-git-fork-thebigrick-mis-6e2820-bigcommerce-platform.vercel.app) | | Nov 29, 2024 3:16pm | | **catalyst-uk** | ⬜️ Ignored ([Inspect](https://vercel.com/bigcommerce-platform/catalyst-uk/Cw5cPTuXbBkTP5G2e6aTZwqTSb3j)) | [Visit Preview](https://catalyst-uk-git-fork-thebigrick-mis-90fa30-bigcommerce-platform.vercel.app) | | Nov 29, 2024 3:16pm |
thebigrick commented 1 day ago

I just fixed a typo in the en.json file causing a build failure

github-actions[bot] commented 23 hours ago

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-9eop7vixt-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 77
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85