search

bigcommerce / stencil-cli

BigCommerce Stencil emulator for local theme development
https://developer.bigcommerce.com/stencil-docs
BSD 4-Clause "Original" or "Old" License
101 stars 141 forks source link

Custom page layouts no longer loading locally #982

Open scottxtensive opened 2 years ago

scottxtensive commented 2 years ago

Expected behavior

If you add a customLayout page template to your theme, it should load the page locally. E.g:

"customLayouts": {
        "brand": {},
        "category": {},
        "page": {
            "custom.html": "/custom"
        },
        "product": {}
},

Actual behavior

Page just loads indefinitely. On the console it does state an upcoming get request, but nothing ever loads.

Steps to reproduce behavior

Add a custom page template to templates -> custom -> page -> custom.html and add the config to map it above.

I do see there is a new Pages V3 api which could be related.

If you try load a page that doesn't exist, the 404 page will load normally.

Environment

Stencil-cli version stencil --version: 6.14.17

Node version node -v: v14.19.3

NPM version npm -v: 6.14.17

OS: Mac 12.5.1 Ventura M1.

scottxtensive commented 2 years ago

Update: looks like it's either been a temporary issue or it's explicitly requiring a trailing slash - /custom/ - Not been an issue before so perhaps documentation could be updated if this is now required.

dadameck commented 2 years ago

We are having the same issue with webpages loading indefinitely, but for us it is happening on default pages.

stencil --version 5.2.0

Node version 14.19.3

NPM version 6.14.17

OS: Windows 10

sacr3dc0w commented 2 years ago

Update: looks like it's either been a temporary issue or it's explicitly requiring a trailing slash - /custom/ - Not been an issue before so perhaps documentation could be updated if this is now required.

https://github.com/bigcommerce/stencil-cli/pull/1000 fixed this for me