search

bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.32k stars 1.65k forks source link

[BUG] Unnecessary fonts update due to PR #2824 #2851

Closed kisslorand closed 10 months ago

kisslorand commented 1 year ago

Description

Updating to latest master the user is asked to update the fonts ~and icons also~. This is a waste of time because no ~icons or~ fonts were changed/updated.

Steps to reproduce

  1. Update to latest master

Expected behavior No fonts ~and icons~ update are requested

Actual behavior Fonts ~and icons~ update are requested

~Additional Information~

~This issue might be irrelevant given the severity of the issues the mentioned PR brings. Check it out here: https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/issues/2850~

Later edit: Looking up the code I understood why the update of the icons is necessary. It is because language size increased so the icons must go to a separate address in the flash memory leaving room for the increased space needed for the language.

github-actions[bot] commented 7 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.