bigtreetech / BIGTREETECH-TouchScreenFirmware

support TFT35 V1.0/V1.1/V1.2/V2.0/V3.0, TFT28, TFT24 V1.1, TFT43, TFT50, TFT70
GNU General Public License v3.0
1.32k stars 1.65k forks source link

[FR] Home button in the corner leveling menu #2855

Closed radek8 closed 10 months ago

radek8 commented 1 year ago

I'm missing the Home button in the corner leveling menu. If I move the screws, the center of the bed also moves, and I would like to execute the G28 command again. If the M48 button were moved elsewhere, there would be a free position. The M48 button is not important when leveling corners. The M48 button is already in the BL-Touch menu.

What do you think about replacing the M48 button with a Home button?

kisslorand commented 1 year ago

What do you think what would be a better option? To home all axes or only Z?

radek8 commented 1 year ago

Both options are possible, but you can only choose one :-) For most users, only the Z axis would probably be enough. My opinion is that the G28 Z would be enough. Complete Home is done at first start, then the X and Y axis are held by the stepper motors. Corner leveling doesn't take long to time out the stepper motors.

radek8 commented 1 year ago

Could a condition be used? If the stepper motors hold, will G28 be executed Z if the motors do not hold, will G28 be executed? The display probably has no way of detecting whether the stepper motors are active.

kisslorand commented 1 year ago

The ideal situation would by entering into this menu to disable Y steppers idle timeout and when exiting from this menu to restore original idle timeout value. Unfortunately there is no way to enquire the idle timeout value set up in Marlin. Your reasoning about using G28 Z seems valid to me. I was also thinking about making that button to home only Z when pressed short and home XYZ when pressed long. The problem is that users most probably would be unaware of the long press function of that button. Another solution could be to replace "Distance" with "Next" and that button to rotate the function of the "Home" button between "Distance", "Home All" and "Home Z".

What do you think?

radek8 commented 1 year ago

Switching parameters with the Next button is useless. I would set the G28 z. If someone wants Home for all axes, they can clean up the parameter and recompile. If he can't do it, I'll be happy to help him with it if he asks :-)

kisslorand commented 1 year ago

How does this look?

L corner_0

radek8 commented 1 year ago

Nice

sarvenn commented 1 year ago

This is only required for printers that uses a probe for Z homing, right?

kisslorand commented 1 year ago

The whole menu is useful only for printers that use a probe for Z homing.

digant73 commented 1 year ago

it should be better a submenu as done in other menus (e.g. Manual Leveling menu)

kisslorand commented 1 year ago

it should be better a submenu as done in other menus (e.g. Manual Leveling menu)

Hmmmm, I was just about to propose the removal of the submenu in the manual leveling menu because in my opinion "DisarmXY" has no practical use there.

Original:
Leveling_0

Proposed: Leveling_1

kisslorand commented 1 year ago

PR #2825 is updated now with the changes discussed with the OP.

digant73 commented 1 year ago

basically the opposite of #2633 and what users ask for

kisslorand commented 1 year ago

basically the opposite of #2633 and what users ask for

Sorry, I do not understand. What is exactly what users are asking for that is implemented in https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/pull/2633 and taken away in #2825?

digant73 commented 1 year ago

basically the opposite of #2633 and what users ask for

Sorry, I do not understand. What is exactly what users are asking for that is implemented in #2633 and taken away in #2825?

People asks for integrating new/missing settings not to replace a feature with his preferred one. In #2825 you removed two functions (one in LevelCorner and one in Leveling). The unlock function in Leveling is useful for a fast/initial setup of the bed (moving the nozzle all around the bed) before fine tuning with knobs and eventually with LevelCorner (for printers with a probe). I also use it Don't forget to re-enable the ban!

rondlh commented 1 year ago

Don't forget to re-enable the ban!

LOL! Don't worry, fools will be fools :D

kisslorand commented 1 year ago

People asks for integrating new/missing settings not to replace a feature with his preferred one. In https://github.com/bigtreetech/BIGTREETECH-TouchScreenFirmware/pull/2825 you removed two functions (one in LevelCorner and one in Leveling). The unlock function in Leveling is useful for a fast/initial setup of the bed (moving the nozzle all around the bed) before fine tuning with knobs and eventually with LevelCorner (for printers with a probe). I also use it

Understood, thanks for the clarifications. You think people need to know the standard deviation of their probe before/during/after doing the corner leveling and also they need to enter into the manual leveling menu to be able to do the "moving the nozzle all around the bed" by hand, which is a very stupid thing to do, it can fry the motherboard. Anyway, the disarm button is available in the parent menu (Menu -> Move), so if anyone has this special need than the steppers can be disabled just before entering into the manual leveling menu. Duh! BTW, I heard someone has a new puppy, do not forget to pet him. He seems to be so happy barking at people you dislike, all he needs in return just approval and some attention from you.

Don't forget to re-enable the ban!

No need, there's an automated troll detection activated.

LOL! Don't worry, fools will be fools :D

- Sparky! Where's the bad man?! - Wufff! Wufff!


Note to people in their right mind: PLEASE DO NOT activate the stepper motors by hand! It can be fatal for the motherboard. I know it the hard way.

digant73 commented 1 year ago

It's up to you to provide another PR difficult to be merged. The request from radek8 was lawful and involving a specific menu very easy to be satisfied. FR received a suggestion from what you consider one of more enemies and as result then you put your effort on changing something your enemy referred to instead of what has been requested by this FR adding/justifying your changes with your usual non sense words and bug reports. I usually provide support to all users requesting help, clarification and support for improving the project. You were also one of them before you manifested your controversial attitude with the whole community cutting by yourself any collaboration even with all the rest of the team banning people here and there. I'm not afraid/happy if you don't understand you are firstly ridiculing yourself with your childish behavior, to say at least, I'm only sorry you put so much effort on providing spites in the project most of the time. Here, simply another clear example.

EDIT: It's up to you to believe this is a good way to put some light or possibly only shadows to your personal repository. it's very hard for a closed project to have followers and longevity. It is even more difficult if users asking for help will be insulted/banned sooner or later or teased with false proclamations. Maybe, you could make it more appealing migrating all of your exclusive and perfectly working open PRs from this to your repo ;-). It's difficult to stay with one foot in two shoes.

kisslorand commented 1 year ago

Most certainly you have the right to your own opinion.

I will not lower myself to your level and call you names, anyone around here mature enough can see what's there to see.

As a side note, thank you very much for the free publicity, bringing the attention towards me will help more and more people to try the alternative FW from my repository and the result of the work I've done there would be the truth, not what random trolls are mumbling on the internet. The only thing people care about is to have finished prints done as perfectly as possible. The proof is in the pudding.

rondlh commented 1 year ago

LOL! Don't worry, fools will be fools :D

@kisslorand Got ya! How did you know I was talking about you :D But if the shoe fits... Nobody cares about your buggy and slow repository, you must be out of your mind to even consider it. Your code is of very poor quality, because you do not communicate, coordinate, test or do peer reviews. Of course the outcome cannot be taken seriously. Your false performance claims have been debunked over and over again. Everyone: Be smart, don't install closed source firmware from other sites/repositories, it could be ransomware. Don't forget to re-enable the ban!

kisslorand commented 1 year ago

LOL. Sparky woke up and started barking to defend his master...

Don't forget to re-enable the ban!

Hmmm. Actually I am enjoying the show. Can you show us again how you're chasing your tail?

As a side note, thank you very much for the free publicity, bringing the attention towards me will help more and more people to try the alternative FW from my repository and the result of the work I've done there would be the truth, not what random trolls are mumbling on the internet. The only thing people care about is to have finished prints done as perfectly as possible. The proof is in the pudding.

github-actions[bot] commented 7 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.