digant73 commented 11 months ago

IMPROVEMENTS:

cumulative patches/improvements: it includes some fixes/improvements provided up to PR #2844. They have been refined/fixed here and there to be fully working. All credits to kisslorand
cumulative cleanup: cleanup on different files just to remove from .h files useless references to functions invoked only internally on related .c files. Order of functions have been changed in .c files just to make cleanup on related .h files. inline function qualifier used when needed to reduce code size
other minor improvements/cleanup

BUGFIXES:

2881
wrong allocated array for monitoring 4 heaters (such as 2 hotend+bed+chamber), displayed as persistent info on title bar, with possible unpredictable side effects (e.g. freezes)

fixes #2881 and wrong allocated buffer for temperature monitoring fixes #2855 fixes #2854 (FR already implemented) fixes #2851 (not an issue) fixes #2849 fixes #2815 fixes #2814 (answer provided) fixes #2786 (replaced by 2853) fixes #2797

PR STATE: ready for merge

rondlh commented 10 months ago

I think this also fixes #2804

digant73 commented 10 months ago

I think this also fixes #2804

2805 should be enough to fix your issue reported in #2804 (let me know if it was not enough to completely fix your issue and this PR fixes it) but it is not able to handle 4 heaters such as 2 hotend+bed+chamber. In particular, an invalid access in main memory (array defined as static in `loopTemperatureStatus` function) is performed with possible unpredictable side effects.

rondlh commented 10 months ago

I think this also fixes #2804

2805 should be enough to fix your issue reported in #2804 (let me know if it was not enough to completely fix your issue and this PR fixes it) but it is not able to handle 4 heaters such as 2 hotend+bed+chamber. In particular, an invalid access in main memory (array defined as static in loopTemperatureStatus function) is performed with possible unpredictable side effects.

Correct, #2805 is enough, but #2873 seems to supersedes it and #2804 is not merged, and should probably not be merged anymore after #2873.

bigtreetech / BIGTREETECH-TouchScreenFirmware

cumulative patches + cleanup #2873

2881