bihealth / cubi-tk

CUBI Tooling for SODAR, VarFish et al.
MIT License
4 stars 6 forks source link

archive copy hangs #160

Closed ericblanc20 closed 1 year ago

ericblanc20 commented 1 year ago

Describe the bug cubi-tk archive copy hangs for large archived directories

Expected behavior The hashdeep audit should complete, regardless of its final status.

Additional context The cause is probably found in the way hashdeep is called from the python code. When there are large number of files & directories that cannot be verified (for example because of restricted permissions), the warning messages swamp stderr, causing the pipe to hang. If the pipe is removed from the subprocess.Popen call, and wait is used rather than communicate, the problem should disappear.