bihealth / cubi-tk

CUBI Tooling for SODAR, VarFish et al.
MIT License
4 stars 6 forks source link

refactor!: Move ISA-Tab templates into a separate repository (#96) #170

Closed mikkonie closed 1 year ago

mikkonie commented 1 year ago

This is a pull request for #96.

The new separate template repo cubi-isa-templates can be found here.

This is still a draft, please comment or improve as you need fit. I haven't published the package on PyPI yet and I don't recommend merging this until there's a proper PyPI dependency.

I've been unable to test this locally because I run into some errors with varfish-cli dependencies (see below). Some cubi-tk expert might want to tell me what I'm doing wrong.

mikkonie commented 1 year ago

Getting the following conflict locally: pkg_resources.ContextualVersionConflict: (attrs 23.1.0 (/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages), Requirement.parse('attrs<22.0,>=21.2.0'), {'varfish-cli'})

Once I attempt installing the expected depdndencies, the result is:

pkg_resources.ContextualVersionConflict: (attrs 23.1.0 (/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages), Requirement.parse('attrs<22.0,>=21.2.0'), {'varfish-cli'})

Traceback (most recent call last):
  File "/home/mikkopen/.virtualenvs/cubi-tk/bin/cubi-tk", line 11, in <module>
    load_entry_point('cubi-tk', 'console_scripts', 'cubi-tk')()
  File "/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages/pkg_resources/__init__.py", line 489, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2852, in load_entry_point
    return ep.load()
  File "/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2443, in load
    return self.resolve()
  File "/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2449, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/home/mikkopen/code/cubi-tk/cubi_tk/__main__.py", line 26, in <module>
    from .sea_snap import run as run_sea_snap
  File "/home/mikkopen/code/cubi-tk/cubi_tk/sea_snap/__init__.py", line 26, in <module>
    from .itransfer_raw_data import setup_argparse as setup_argparse_itransfer_raw_data
  File "/home/mikkopen/code/cubi-tk/cubi_tk/sea_snap/itransfer_raw_data.py", line 7, in <module>
    from ..snappy.itransfer_common import SnappyItransferCommandBase
  File "/home/mikkopen/code/cubi-tk/cubi_tk/snappy/__init__.py", line 56, in <module>
    from .varfish_upload import setup_argparse as setup_argparse_varfish_upload
  File "/home/mikkopen/code/cubi-tk/cubi_tk/snappy/varfish_upload.py", line 11, in <module>
    from varfish_cli.__main__ import main as varfish_cli_main
  File "/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages/varfish_cli/__main__.py", line 13, in <module>
    from varfish_cli.case import run as run_case
  File "/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages/varfish_cli/case/__init__.py", line 9, in <module>
    from varfish_cli.case.list_case import setup_argparse as setup_argparse_list
  File "/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages/varfish_cli/case/list_case.py", line 9, in <module>
    import attrs
ModuleNotFoundError: No module named 'attrs'
github-actions[bot] commented 1 year ago

Please format your code with black: make black.

sellth commented 1 year ago

Tests run fine for me. Had similar issues until I realised that pytest was not called from my venv but from .local/bin

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 93.10% and project coverage change: -0.11% :warning:

Comparison is base (3939f83) 75.59% compared to head (76fa3cc) 75.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #170 +/- ## ========================================== - Coverage 75.59% 75.48% -0.11% ========================================== Files 98 98 Lines 7806 7767 -39 ========================================== - Hits 5901 5863 -38 + Misses 1905 1904 -1 ``` | [Files Changed](https://app.codecov.io/gh/bihealth/cubi-tk/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bihealth) | Coverage Δ | | |---|---|---| | [cubi\_tk/isa\_tpl/\_\_init\_\_.py](https://app.codecov.io/gh/bihealth/cubi-tk/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bihealth#diff-Y3ViaV90ay9pc2FfdHBsL19faW5pdF9fLnB5) | `95.00% <71.42%> (ø)` | | | [cubi\_tk/archive/readme.py](https://app.codecov.io/gh/bihealth/cubi-tk/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bihealth#diff-Y3ViaV90ay9hcmNoaXZlL3JlYWRtZS5weQ==) | `83.23% <100.00%> (ø)` | | | [tests/test\_isa\_tpl.py](https://app.codecov.io/gh/bihealth/cubi-tk/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bihealth#diff-dGVzdHMvdGVzdF9pc2FfdHBsLnB5) | `100.00% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/bihealth/cubi-tk/pull/170/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bihealth)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.