search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

DataCellEditor beforeDestroy() called twice #869

Open mikkonie opened 4 years ago

mikkonie commented 4 years ago

Noticed this while developing #834. I'm guessing this is a bug in the latest ag-grid version, because I haven't changed anything in the editor behaviour.

Need to think of a workaround.

mikkonie commented 4 years ago

Seems the entire destruction hook runs twice since destroy() has the same problem.

A crude workaround is to add a flag to the component data to ensure the actual code only gets executed once.

Will try to see if someone has reported this or if it's indeed something dumb I've done.

mikkonie commented 4 years ago

mentioned in commit aca4a1c0501285d7f513d70c258240bb5ab3f2a1

mikkonie commented 4 years ago

mentioned in commit 66410a7d8e0ddf8f4595c9485a0bccda351c0590

mikkonie commented 4 years ago

mentioned in commit 861065f5fc56bacbd2a20d7ded0c05b3f47b412e

mikkonie commented 4 years ago

mentioned in commit fbe012133e309e44242f8dd475023355f1fd6554

mikkonie commented 4 years ago

mentioned in commit 62c380672913777b24c14a9d3adc16de715b257d

mikkonie commented 2 years ago

Should see if this is still occurring.