search

bilby-dev / bilby

A unified framework for stochastic sampling packages and gravitational-wave inference in Python.
https://bilby-dev.github.io/bilby/
MIT License
68 stars 75 forks source link

ENH: add Planck15_LAL cosmology #829

Closed mj-will closed 3 weeks ago

mj-will commented 1 month ago

Add the Planck15_LAL cosmology as defined in: https://dcc.ligo.org/DocDB/0167/T2000185/005/LVC_symbol_convention.pdf

Note: there are additional commits in this PR since it requires the PR listed below. It should be rebased before being reviewed.

Requires: https://github.com/bilby-dev/bilby/pull/828

cplb commented 3 weeks ago

I can confirm that these are the conventional numbers dating back to https://arxiv.org/abs/1602.03840

adivijaykumar commented 3 weeks ago

Code-wise this looks good to me! Should we consider adding a test comparing luminosity distances calculated by lal and bilby at some fiducial redshift value(s)? I am not sure the python lal interface allow for this though.

mj-will commented 3 weeks ago

Code-wise this looks good to me! Should we consider adding a test comparing luminosity distances calculated by lal and bilby at some fiducial redshift value(s)? I am not sure the python lal interface allow for this though.

I've added a test for this, for now it uses a manual version of the LAL cosmology but once changes from https://git.ligo.org/lscsoft/lalsuite/-/merge_requests/2368 at in a release, we can switch to that.