search

billimarie / prosecutor-database

An open-source, community oversight dataset of all U.S. Prosecutors. Happy Hacktoberfest 🎃
https://billimarie.github.io/prosecutor-database
Other
89 stars 85 forks source link

[FEATURE] Pagination #62

Open billimarie opened 5 years ago

billimarie commented 5 years ago

Instead of infinite scroll, pagination would be wonderful.

jay-bis commented 4 years ago

Hi! I'm looking to start making open source contributions, and thought this would be a great place to start. I haven't had time to look at the codebase yet, but this is definitely something I would be interested in working on.

billimarie commented 4 years ago

Hi @jay-bis, thanks for reaching out! We'd love your contributions. Feel free to pull down the code on the app branch to take a peak under the hood. If you have any questions, you can always ping me via GitHub.

jay-bis commented 4 years ago

I just started to take a peek - I'm not familiar with the meteor framework/mongoDB, what's the best way to get the attorney data up on my local system? As of now, after going through the setup instructions, there are no attorneys for me to look at.

billimarie commented 4 years ago

@jay-bis Would love to have you contribute if you're still working on open-source. I assigned this issue to you in case you see this note & have time to take a look. The app has changed a bit since we last spoke.

adamellsworth commented 4 years ago

I'd be happy to tackle this (it looks like the other comment was made a year ago).

One question I had was the ./api/*.js files. Are those just mock data to be imported for testing purposes or for reference? The code doesn't seem to reference them anywhere.

Additionally, is there any significance to their IDs? (e.g. "id": "sa-03",)

billimarie commented 4 years ago

Thanks for volunteering, @adamellsworth. It might help to take a look at @jay-bis's pull request here: #66

adamellsworth commented 4 years ago

I've been really overburdened with work these past few weeks and may not be able to address this in a reasonable time-frame. If you'd like to find someone who can devote more time to this issue please do so.

spavitra1 commented 4 years ago

I would like to work on this if help is still needed.