Open issues-guy opened 5 years ago
Am i right in thinking that this isn't easily tweaked as the docker container has the compiled version? can't seem to find these files on the docker container (1.X)
I'd also like this, I'm doing the same thing on my end.
The latest image is now including deluge v2, so the patch in the op is no longer valid.
I've submitted a PR for this feature, feel free to test it and provide feedback (using the image tag below) while the PR is reviewed: ivanfilippov/arch-delugepvn:webui-autologin
I've submitted a PR for this feature, feel free to test it and provide feedback (using the image tag below) while the PR is reviewed: ivanfilippov/arch-delugepvn:webui-autologin
This is great, any chance of a making a Deluge 1.X version.
I'm not super familiar with Arch, but since they've updated their repos to Deluge 2, I don't know if Deluge 1 would still be available for install (without extra effort in the install script) which would make building the image tougher.
I'm interested to know why you're holding off from upgrading to Deluge 2.0, if you don't mind sharing. 😄
Webapi egg doesn't work on 2.0 yet. If you go to binhex/arch-delugevpn:1.3.15_18_ge050905b2-1-04 you get 1.x so if you go to that tag on GitHub you also do. The pr would likely not be accepted but perhaps a fork would work?
Looks like the developer for the WebAPI egg doesn't have time to work on it at the moment, so I took a stab at it (https://github.com/idlesign/deluge-webapi/issues/14#issuecomment-507906530).
It works for me in both standalone deluge and in this docker image, and I've tested all four of the API endpoints the egg implements. Would you be able to try it out with the :latest tag of this image and give feedback? The egg is here.
I'm having issues getting plugins installed via WebUI (I think it's a deluge issue, but I'm still looking into it). If you can install it via that, go for it, otherwise to install it into the docker directly, exec into it, then:
rm -rf /config/plugins/WebAPI*
rm -rf /home/nobody/.cache/Python-Eggs/WebAPI*
curl -o /config/plugins/WebAPI-0.4.2-py3.7.egg https://github.com/ivanfilippov/deluge-webapi/blob/deluge2-fix/dist/WebAPI-0.4.2-py3.7.egg?raw=true
Then restart the container, log in to the WebUI and enable the WebAPI plugin via the Preferences menu.
Let me know how it goes!
@Fma965 I've submitted a PR to the WebAPI repo to add Deluge 2 support (feel free to get the egg from my forked repo until the PR is merged, just make sure to get the latest version, v0.4.3, from the repo instead of what I posted above). Would a 1.x version of this still be needed? I prefer not to maintain a separate fork. 😄
@ivanfilippov Great work, assuming the WebAPI changes actually work on Deluge 2.0 then there is no need for Deluge 1.X :) i will test it later or over the weekend.
Awesome, ignore my note above regarding the version number. The fixes are now merged into the WebAPI repo, grab the 0.4.0 release from https://github.com/idlesign/deluge-webapi/tree/master/dist.
Please let us know how the testing goes so we can close this issue.
So when i enable autologin and the plugin it doesn't work.
i can run it on a fresh config once, but once i restart it after it doesn't start again
___. .__ .__
\_ |__ |__| ____ | |__ ____ ___ ___
| __ \| |/ \| | \_/ __ \\ \/ /
| \_\ \ | | \ Y \ ___/ > <
|___ /__|___| /___| /\___ >__/\_ \
\/ \/ \/ \/ \/
https://hub.docker.com/u/binhex/
2019-09-28 13:35:19.490327 [info] System information Linux 834355cc4c45 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
2019-09-28 13:35:19.509992 [info] PUID defined as '1000'
2019-09-28 13:35:19.531606 [info] PGID defined as '1000'
2019-09-28 13:35:19.565786 [warn] UMASK not defined (via -e UMASK), defaulting to '000'
2019-09-28 13:35:19.584433 [info] Permissions already set for volume mappings
2019-09-28 13:35:19.604949 [info] DELUGE_AUTOLOGIN defined as 'yes'
2019-09-28 13:35:19.621239 [info] Patching deluge to disable login prompt
patching file deluge/ui/web/auth.py
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file deluge/ui/web/auth.py.rej
patching file deluge/ui/web/js/deluge-all-debug.js
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file deluge/ui/web/js/deluge-all-debug.js.rej
Actually it seems to work fine, just need to rebuild the container in portainer after adding the plugin for some reason
I haven't been able to replicate the above in my own setup. Based on your last comment is all good?
super late reply, but no the same thing still happened every time i restart the docker.
in fact now it doesn't start no matter how many times i restart.
fwiw i use portainer and when i make a edit to the config and restart it breaks, a normal restart i've not tried.
So when i enable autologin and the plugin it doesn't work.
i can run it on a fresh config once, but once i restart it after it doesn't start again
___. .__ .__ \_ |__ |__| ____ | |__ ____ ___ ___ | __ \| |/ \| | \_/ __ \\ \/ / | \_\ \ | | \ Y \ ___/ > < |___ /__|___| /___| /\___ >__/\_ \ \/ \/ \/ \/ \/ https://hub.docker.com/u/binhex/ 2019-09-28 13:35:19.490327 [info] System information Linux 834355cc4c45 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux 2019-09-28 13:35:19.509992 [info] PUID defined as '1000' 2019-09-28 13:35:19.531606 [info] PGID defined as '1000' 2019-09-28 13:35:19.565786 [warn] UMASK not defined (via -e UMASK), defaulting to '000' 2019-09-28 13:35:19.584433 [info] Permissions already set for volume mappings 2019-09-28 13:35:19.604949 [info] DELUGE_AUTOLOGIN defined as 'yes' 2019-09-28 13:35:19.621239 [info] Patching deluge to disable login prompt patching file deluge/ui/web/auth.py Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file deluge/ui/web/auth.py.rej patching file deluge/ui/web/js/deluge-all-debug.js Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file deluge/ui/web/js/deluge-all-debug.js.rej
I get this same error, has there been a fix?
I deleted everything and started over, and now I get this error;
2020-01-19 11:52:34.591125 [info] DELUGE_AUTOLOGIN defined as 'yes' 2020-01-19 11:52:34.660429 [info] Patching deluge to disable login prompt patch: **** Can't change to directory /usr/lib/python3.7/site-packages/ : No such file or directory
Can the autologon fix also be applied on binhex/arch-deluge ?
+1 to support this on binhex/arch-deluge would be great for unraid users.
Please add this support to binhex/arch-deluge, it would be awesome.
I'm working on adding this to the latest version of this image, the code is ready but there is a pre-requisite in @binhex scripts repository here: https://github.com/binhex/scripts/pull/4
very easy: just change password to blank password. then you only need to click enter to login.
How is this work going on?
@ivanfilippov did this ever come to life?
This seems like a pretty simple thing to do.. I wonder what the reasoning for not adding support is
+1
I already run Deluge behind reverse proxy with authentication and have blanked out the default password and modify the webui such that it auto logs in without a prompt.
Here is the modification https://dukrat.net/124/deluge-webui-1-3-6-autologin-disable-password
Can there be an environment variable for the docker to perform these actions on boot if it is set to true?
-e DELUGE_AUTOLOGIN=<true|false>
Thanks for your consideration!