search

binhex / arch-privoxyvpn

Docker build script for Arch Linux base with Privoxy and OpenVPN
GNU General Public License v3.0
102 stars 24 forks source link

microsocks enable no auth #10

Closed currowth closed 2 years ago

currowth commented 3 years ago

Can you enable no auth if SOCKS_USER and SOCKS_PASS variables are not passed or empty? This is useful for browsers like firefox that does not have the options for auth. I was able to get it working by modifying microsocks.sh and removing -u and -p param.

Muppetteer commented 2 years ago

Pull request here https://github.com/binhex/arch-privoxyvpn/pull/18

binhex commented 2 years ago

hi thanks for the PR, i have had a look at it and i think i can reduce the code changes down a bit so i took a stab at it, see commit:- https://github.com/binhex/arch-privoxyvpn/commit/5ce70232a29958eb930ff3fd07549ad53372af3b

if you want to try it out then pull down and run 'test' tagged image just built, i tested it locally with and without SOCKS_USER defined and it works as intended for me.

please let me know if it works ok for you and i will then create a new 'latest' tagged image with the change.

Muppetteer commented 2 years ago

Code looks better than mine. It's what I would have done if my bash scripting skills weren't almost non-existent.

I pulled the 'test' tagged image and it works fine. Thanks.