binocarlos / powerstrip-weave

A Powerstrip plugin that runs weave inside a container and ensures that containers are connected to the weave network before running their entrypoints.
36 stars 3 forks source link

Resolve having to mount the docker binary #5

Closed binocarlos closed 9 years ago

binocarlos commented 9 years ago

The Readme and run.sh both do this trick a lot:

$ docker run -d --name powerstrip-weave \
    --expose 80 \
    -v /var/run/docker.sock:/var/run/docker.sock \
    -v /usr/bin/docker:/usr/bin/docker \
    binocarlos/powerstrip-weave launch

Where we should only need to mount the docker socket not the binary itself.

A solution is to download the docker binary inside the container but I then had a version mis-match between the newer docker binary inside the container and the older docker server I was running on my host.

I'm not sure which approach is better and have gone for mounting the docker binary from the host to ensure the same version for the moment - issue pending feedback!

binocarlos commented 9 years ago

resolved by closing #8