binux / pyspider

A Powerful Spider(Web Crawler) System in Python.
http://docs.pyspider.org/
Apache License 2.0
16.48k stars 3.69k forks source link

Potential Side Channel Attack on non-constant time Comparison #997

Open nevercodecorrect opened 6 months ago

nevercodecorrect commented 6 months ago

Expected behavior

The vulnerable code is here, the password comparison should use a constant time algorithm

Actual behavior

The vulnerable code is here. An attacker could leverage the differences between the execution time to recover the secrets. String comparison == is not a constant implementation, the execution time may vary based on how many characters are matched. A constant-time implementation would be recommended. A more detailed explanation could be found here

flowerone commented 6 months ago

您发给我的邮件我已经收到。=================================================== This is an automatic reply, confirming that your e-mail was received.Thank you