search

binwiederhier / ntfy-android

Android app for ntfy.sh
Apache License 2.0
507 stars 104 forks source link

fix(docs): strings.xml -> values.xml in README #57

Closed malmeloo closed 1 year ago

malmeloo commented 1 year ago

app_base_url seems to have been moved to values.xml.

binwiederhier commented 1 year ago

Thanks!

binwiederhier commented 1 year ago

It may also be worth linking to https://docs.ntfy.sh/develop/#android-app since that's where the up-to-date docs are.

malmeloo commented 1 year ago

I think in that case it might be better to drop the building instructions from this repo altogether, just to avoid having possibly conflicting information in the future (if the instructions here don't get updated). I also just noticed that the FDroid instructions in the docs suggest stripping google dependencies, whereas this repo doesn't.

binwiederhier commented 1 year ago

I'm happily accepting PRs for this stuff, but I sadly don't have a ton of time right now to do it myself.

malmeloo commented 1 year ago

No worries, I'll create a pr later today.