search

biocaddie / WG3-MetadataSpecifications

WG3 Metadata Specification
28 stars 13 forks source link

data_analysis_schema.json #7

Closed hsolbrig closed 8 years ago

hsolbrig commented 8 years ago

According to the JSON-Schema specification, "allOf" references a list of objects, "each of which is a schema". The "uses", "input" and "output" elements are objects. We believe that the schema should read:

"allOf": [ { "$ref": "activity_schema.json#" }, { ---> "type": "object", ---> "properties": { "uses": { ... "minItems" : 1 } ---> }

This would be consistent with other uses of "allOf"

agbeltran commented 8 years ago

@hsolbrig thanks you very much for all the reports, we will fix the issues soon. We are also working on a new version of the model and we will make sure to update the JSON schemas to the new version (and we will make sure they are correct!)

hsolbrig commented 8 years ago

We (Dr. Jiang and Harold Solbrig, Mayo clinic) are using the schemas to create maps from dbGaP to bioCaddie submissions as well as to guide conversions to RDF for annotation. We’ll be contacting you with a number of questions..

On Feb 19, 2016, at 1:53 AM, Alejandra Gonzalez-Beltran notifications@github.com wrote:

@hsolbrig https://github.com/hsolbrig thanks you very much for all the reports, we will fix the issues soon. We are also working on a new version of the model and we will make sure to update the JSON schemas to the new version (and we will make sure they are correct!)

— Reply to this email directly or view it on GitHub https://github.com/biocaddie/WG3-MetadataSpecifications/issues/7#issuecomment-186107646.