search

biocore / deblur

Deblur is a greedy deconvolution algorithm based on known read error profiles.
BSD 3-Clause "New" or "Revised" License
92 stars 41 forks source link

skip trimming option #124

Closed mortonjt closed 7 years ago

mortonjt commented 7 years ago

This adds an option to ignore trimming.

So you should be able to specify a flag to completely ignore trimming.

Here a test case is added. In addition, I have tested out the CLI on some of the test datasets. Note that this is a little tricky to test, so any suggestions on improving this will be welcome.

But I believe that this should cover the gist of it.

wasade commented 7 years ago

thanks! there are some failures btw

cc @antgonza

mortonjt commented 7 years ago

A fix for the file path is coming in - its passing on my system. But this is ready for review.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 88.98% when pulling b1c0c8c8156f2433f6a9c3ea1f6a9f585fedc5e8 on mortonjt:version-1.7 into b377d4a488d91647b0dce9ce90a8a56da51f4b7c on biocore:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 89.162% when pulling a5e4b7e9c4a637cc5bc24f85481133336dbaff76 on mortonjt:version-1.7 into b377d4a488d91647b0dce9ce90a8a56da51f4b7c on biocore:master.

mortonjt commented 7 years ago

Ok. I think this is ready to merge!

mortonjt commented 7 years ago

Thanks!