search

biocore / emperor

Emperor a tool for the analysis and visualization of large microbial ecology datasets
http://biocore.github.io/emperor/
Other
52 stars 50 forks source link

Force gradient SVG to cover the full color map and gradient ranges #789

Closed fedarko closed 3 years ago

fedarko commented 3 years ago

Closes #788. This solution should also be applicable to https://github.com/biocore/empress/issues/421.

fedarko commented 3 years ago

Not sure why the build is failing -- it doesn't look like it's the JS tests' problem. Seems like it might be a NumPy version issue, judging by the errors that show up and the fact that just the NUMPY_VERSION="<1.13" builds fail.

image

ElDeveloper commented 3 years ago

@fedarko, would you be able to git pull upstream master to get the latest changes in your local branch. And then push to re-run the CI. I just migrated the project from Travis to GitHub actions so things should work. 😟

fedarko commented 3 years ago

@ElDeveloper just re-pushed; looks like the build is passing now.

ElDeveloper commented 3 years ago

Thanks so much @fedarko. One last request, can you add a note to the ChangeLog? Other than that, this should be ready to go.

fedarko commented 3 years ago

@ElDeveloper -- Got it, added a note to the changelog. Thanks!

ElDeveloper commented 3 years ago

Thanks @fedarko !