search

bioio-devs / bioio-tifffile

A BioIO reader plugin for reading TIFFs using Tifffile
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

is_mmstack is required but tifffile dependency is older #22

Open toloudis opened 2 hours ago

toloudis commented 2 hours ago

Describe the Bug

this plugin uses tifffile's is_mmstack parameter but that parameter was only added after our minimum tifffile dependency requirement

Expected Behavior

consistency of dependency version with implementation

From Filip:

File "/home/filip.sluzewski/.pyenv/versions/3.10.14/envs/trackastra/lib/python3.10/site-packages/bioio_tifffile/reader.py", line 463, in _read_delayed
    with TiffFile(open_resource, is_mmstack=False) as tiff:
  File "/home/filip.sluzewski/.pyenv/versions/3.10.14/envs/trackastra/lib/python3.10/site-packages/tifffile/tifffile.py", line 3928, in __init__
    raise TypeError(f'unexpected keyword argument: {key}')
TypeError: unexpected keyword argument: is_mmstack

...

pip freeze | grep tiff
bioio-ome-tiff==1.0.0
bioio-tifffile==1.0.0
tifffile==2023.2.28
toloudis commented 2 hours ago

v2023.3.15 seems to be the first where is_mmstack shows up